Mem time redo #733
Merged
Mem time redo #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdc-mitzimorris
requested review from
damonbayer,
dylanhmorris and
sbidari
as code owners
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
+ Coverage 26.08% 26.28% +0.20%
==========================================
Files 26 26
Lines 2427 2427
==========================================
+ Hits 633 638 +5
+ Misses 1794 1789 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
damonbayer
reviewed
Nov 19, 2025
damonbayer
reviewed
Nov 19, 2025
damonbayer
approved these changes
Nov 19, 2025
Collaborator
damonbayer
left a comment
damonbayer
left a comment
There was a problem hiding this comment.
LGTM, with a few small suggestions.
Co-authored-by: Damon Bayer <[email protected]>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more tests for pyrenew_hew's
PyrenewHEWDataclass.This is part 1 of a do-over of #709. It doesn't change any of the code in
pyrenew_hew_data.py, except to add a docstring for functionto_forecast_data. PR 709 made a breaking change to this function; the added documentation is intended prevent future mistakes.Part 2 of this do-over will use the functions in
PyRenew/pyrenew/time.py. specifically:align_observation_timescreate_date_time_spineget_end_dateget_n_data_daysvalidate_mmwr_dates,Currently, these are defined as methods in class
PyrewnewHEWData; part 2 will change the calls inPyrewnewHEWDatafromself.get_end_datetoget_end_date, etc.